search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.91k stars 3.06k forks source link

CSS variables tests should require trimming values #34880

Open mgol opened 2 years ago

mgol commented 2 years ago

There was a spec change a few years ago requiring spaces around CSS declaration's value to be trimmed: https://github.com/w3c/csswg-drafts/pull/1986. The discussion leading to this spec change: https://github.com/w3c/csswg-drafts/issues/774.

The PR is marked as tested but the CSS Variable tests at https://github.com/web-platform-tests/wpt/blob/246b1bbb31f5cfa50dcd9cf0e91a14b32d9faf4e/css/css-variables/variable-definition.html don't seem to account for that. For example, the trailing white space (single space) test requires the following input: "--var:value " to result in the value "value " - note the trailing space.

cdumez commented 1 year ago

Should be fixed in https://github.com/web-platform-tests/wpt/pull/37239.

cdumez commented 1 year ago

Actually never mind, I fixed the ones in css/css-typed-om but based on the original report, there are similar issues in other folders (which I haven't addressed).