web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
5k stars 3.1k forks source link

Fetch Metadata test expectations in light of Mixed Content upgrading for image, audio, video #37080

Open mozfreddyb opened 1 year ago

mozfreddyb commented 1 year ago

Hi,

we at Mozilla are increasing our readiness to adopt the upgrading of mixed content and intend to ship it in Nightly soon. Something we've observed is that this will modify the expected behavior for a variety of fetch metadata tests - specifically those testing the "HTTPS downgrade-upgrade" scenario.

What's the suggested pace for updating the tests within wpt when not everyone is already implementing this yet?

CCing @estark37 @jugglinmike

annevk commented 1 year ago

Generally the tests should be updated to match the latest specifications.

One problem here is that Fetch doesn't hook into this newer version of Mixed Content yet. That probably ought to be fixed so it's crystal clear what the values have to be.

carlosjoan91 commented 1 year ago

I'll go ahead and send a PR for adding the missing call to https://w3c.github.io/webappsec-mixed-content/#upgrade-algorithm in main fetch so the tests can match that.