search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
5k stars 3.1k forks source link

Non-inclusive language in third-party #39998

Open annevk opened 1 year ago

annevk commented 1 year ago

For now I wanted this to be on the record. If we can do things to shrink this list that would be great and I'd be willing to help.

% report-non-inclusive-language --verbose
tools/manifest/tests/test_manifest.py: blacklist: 1
tools/third_party/py/CHANGELOG.rst: slave: 1
tools/third_party/py/doc/announce/release-1.2.0.txt: slave: 1
tools/third_party/py/doc/announce/release-1.3.0.txt: slave: 1
tools/third_party/py/doc/announce/release-1.3.2.txt: slave: 1
tools/third_party/h2/tox.ini: whitelist: 2
tools/third_party/attrs/pyproject.toml: whitelist: 1
tools/third_party/pytest/tox.ini: whitelist: 1
tools/third_party/pytest/doc/en/changelog.rst: blacklist: 1
tools/third_party/pytest/doc/en/changelog.rst: slave: 1
tools/third_party/pytest/doc/en/reference/reference.rst: whitelist: 1
tools/third_party/html5lib/CHANGES.rst: whitelist: 1
tools/third_party/html5lib/benchmarks/data/html.html: blacklist: 1
tools/third_party/html5lib/benchmarks/data/html.html: whitelist: 4
tools/third_party/typing_extensions/src/typing_extensions.py: whitelist: 3
_venv3/lib/python3.10/site-packages/pip/_internal/operations/check.py: whitelist: 4
_venv3/lib/python3.10/site-packages/pip/_vendor/typing_extensions.py: whitelist: 2
_venv3/lib/python3.10/site-packages/pip/_vendor/urllib3/util/retry.py: blacklist: 5
_venv3/lib/python3.10/site-packages/pip/_vendor/urllib3/util/retry.py: whitelist: 23
_venv3/lib/python3.10/site-packages/yaml/constructor.py: blacklist: 8
_venv3/lib/python3.10/site-packages/setuptools/_vendor/typing_extensions.py: whitelist: 3
_venv3/lib/python3.10/site-packages/pkg_resources/_vendor/typing_extensions.py: whitelist: 2
Total: 68 (blacklist: 16, whitelist: 47, slave: 5)
gsnedders commented 1 year ago

If we can do things to shrink this list that would be great and I'd be willing to help.

I guess the questions are:

  1. Has this been fixed upstream (in py, h2, attrs, etc.)? (If not, plz file PRs upstream!)
  2. Have the upstream projects made a release with this fixed?
  3. Does that release support at least all the Python versions we care about?
  4. Is there any other reason why we shouldn't upgrade our dependency?

Note that:

tools/manifest/tests/test_manifest.py: blacklist: 1

…isn't in third-party and someone (you, since you volunteered? 😜) should just fix that.

annevk commented 1 year ago

Do we run the latest version of hypothesis as https://github.com/HypothesisWorks/hypothesis/pull/3742 was only patched a month ago? If we do we could replace that instance with exclude_characters.