search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
5k stars 3.1k forks source link

[eme] Clarify name and description of clear-encrypted and encrypted-clear tests #4075

Open ddorwin opened 8 years ago

ddorwin commented 8 years ago

It's not immediately clear from the filenames and descriptions of *-mp4-playback-temporary-clear-encrypted.html and *-mp4-playback-temporary-encrypted-clear.html what exactly they are testing. In some discussions, they have been grouped into the failing "temporary" tests.

These tests are testing the ability of an implementation to transition between encrypted and unencrypted segments (not just blocks). (Is segments the right word?) These specific files use different moov boxes. See https://github.com/w3c/web-platform-tests/issues/3956#issuecomment-253569171 for more details.

It seems that *-mp4-playback-transition-segments-clear-encrypted or something similar would be more meaningful.

ddorwin commented 8 years ago

The names are even more confusing because of the "-mp4-playback-temporary-encrypted-clear-sources.html" tests, which test something different.

jdsmith3000 commented 8 years ago

I have no objection to clarifying these names, but recognized them as special from their current names. They are also fairly viewed as edge temporary cases, right? At any rate, adding transition to the name can't hurt...