Open juliandescottes opened 1 year ago
@thiagowfx wanted to sync quickly. I'm added some basic tests for add/remove intercept and maybe you're doing the same? Should we collaborate on a PR?
@juliandescottes Sorry for the delay, I was sporadically OOO during the last few weeks.
The invalidation tests are great so far. I think there may be some cases still missing, I am trying to identify them to add a couple more.
Now, regarding the core implementation itself: I believe we'll kickstart this in Chromium this week. If so, then I'll start to draft some tests as well. Let me know if you get to them first.
@thiagowfx sounds great!
At the moment, I uploaded some tests and wdspec changes at:
I didn't attempt to cover the AuthRequired phase because I don't have the corresponding event implemented. And they're also not testing the commands to "handle" a blocked request. So it's mostly about adding intercepts and checking if requests are blocked or not.
I can have them on a PR here if you want to take a look?
I can have them on a PR here if you want to take a look?
That would be great!
We currently have tests for invalid arguments for both commands, we should synchronize to add more practical tests.