search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
5.03k stars 3.12k forks source link

Lazy loading image from the list of available images #42479

Open pgorszkowski-igalia opened 1 year ago

pgorszkowski-igalia commented 1 year ago

I am working on fix for "lazy loading image from the list of available images" in case of WebKit (https://github.com/WebKit/WebKit/pull/18271). I use test: http://wpt.live/html/semantics/embedded-content/the-img-element/image-loading-lazy-use-list-of-available-images.html but it seems that there are no tests for the cases when cached image and "lazy loading" image differs with crossorigin values (not specified, empty, anonymous, use-credentials), which should have impact how cached image from the list of available images can be reused by new image (with lazy loading). Based on test: http://wpt.live/html/semantics/embedded-content/the-img-element/image-loading-lazy-use-list-of-available-images.html it should be easy to create such test cases.

pgorszkowski-igalia commented 1 year ago

@domfarolino: WDYT?

domfarolino commented 1 year ago

So you'd like to extend that test to add another one where the lazyload imge and the image in the list of available images differ by crossorigin, so we can show that the image does not load immediately (from the list of available images), but instead gets deferred like a normal image? If so, that seems reasonable. Do you have a PR up to modify the test or anything?

pgorszkowski-igalia commented 1 year ago

So you'd like to extend that test to add another one where the lazyload imge and the image in the list of available images differ by crossorigin, so we can show that the image does not load immediately (from the list of available images), but instead gets deferred like a normal image?

Yes, exactly

Do you have a PR up to modify the test or anything?

Not yet but I can prepare, will add you as reviewer there.

Thanks

pgorszkowski-igalia commented 1 year ago

https://github.com/web-platform-tests/wpt/pull/42780