The registerAttributionSrc helper function returned a promise
corresponding to completion of the various requests it can send, but in
general that completion is irrelevant to the behavior of these tests,
which previously used them to orchestrate a source registration
finishing before a trigger registration.
Unfortunately, completion of the request has no bearing on completion
of the response handling in the browser when the source and trigger
registrations occur in different redirect chains.
As such, the corresponding awaits were meaningless at best. Instead,
tests covering the behavior of source and trigger registrations in
separate redirect chains need to use the waitForSourceToBeRegistered
helper, which polls the server for verbose debug reports corresponding
to successful source registration.
Separately, it's not necessary to wait for a trigger registration to
complete beore polling reports.
In a followup change I will consolidate separate redirect chains where
that behavior is not specifically being tested.
The registerAttributionSrc helper function returned a promise corresponding to completion of the various requests it can send, but in general that completion is irrelevant to the behavior of these tests, which previously used them to orchestrate a source registration finishing before a trigger registration.
Unfortunately, completion of the request has no bearing on completion of the response handling in the browser when the source and trigger registrations occur in different redirect chains.
As such, the corresponding awaits were meaningless at best. Instead, tests covering the behavior of source and trigger registrations in separate redirect chains need to use the waitForSourceToBeRegistered helper, which polls the server for verbose debug reports corresponding to successful source registration.
Separately, it's not necessary to wait for a trigger registration to complete beore polling reports.
In a followup change I will consolidate separate redirect chains where that behavior is not specifically being tested.
Bug: 349397580, 349011165, 348594906 Change-Id: Id2e79525257567fd3bcb2249188fb04de2e43b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5659020 Reviewed-by: Nan Lin \linnan@chromium.org Commit-Queue: Andrew Paseltiner \apaseltiner@chromium.org Cr-Commit-Position: refs/heads/main@{#1319855}