web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.93k stars 3.07k forks source link

Add support for quotes in @page margin boxes content. #46916

Closed chromium-wpt-export-bot closed 3 months ago

chromium-wpt-export-bot commented 3 months ago

Since quotes create an extra level of layout objects, it will no longer be a simple LayoutBlockFlow (page margin box) with leaf nodes, so that the existing IsDetachedNonDomRoot() would fail when building the layout object tree. Therefore change this flag (which is only used when DCHECKs are enabled) to be set for the entire non-DOM tree, rather than just on its root.

Bug: 40341678 Change-Id: Ie5e9ca34491b42dcff9ad029aa0fe8fedcce45ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5658437 Reviewed-by: Ian Kilpatrick \ikilpatrick@chromium.org Reviewed-by: Daniil Sakhapov \sakhapov@chromium.org Commit-Queue: Morten Stenshorne \mstensho@chromium.org Cr-Commit-Position: refs/heads/main@{#1320273}