search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.79k stars 2.99k forks source link

Rename address space override ports from private to local #46942

Open atjn opened 3 days ago

atjn commented 3 days ago

The RFC for this feature was changed to use local instead of private, but the implementation of the feature was never renamed. This should fix the renaming. Link to the RFC rename: https://github.com/web-platform-tests/rfcs/pull/135

Please note that this feature was originally created to test the implementation of the private-network-access spec, and it is unclear whether that spec will keep its name or be renamed to local-network-access. It is however clear that "local" better describes what this feature is providing. Given that this WPT feature is not tied to the private-network-access spec, and can be used to test many other specs, it should use the best available name, and that name is "local". Link to discussion on this: https://github.com/web-platform-tests/wpt/pull/38939

atjn commented 3 days ago

As far as I can tell, the flaky test results in chrome are not caused by these changes. My guess would be that the HTTP server was too slow in the test machine.