web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.8k stars 3k forks source link

Add failing COOP noopener-allow-popups tests and flags #46979

Closed chromium-wpt-export-bot closed 13 hours ago

chromium-wpt-export-bot commented 5 days ago

This CL adds the flags and failing tests for [1], to clearly separate them from the functional changes.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5581251

Bug: 344963946 Change-Id: I1320fd6893a3ba25d93f89efd5a30e151a69889b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640893 Commit-Queue: Yoav Weiss (@Shopify) \yoavweiss@chromium.org Reviewed-by: Vladimir Levin \vmpstr@chromium.org Reviewed-by: Arthur Sonzogni \arthursonzogni@chromium.org Cr-Commit-Position: refs/heads/main@{#1322722}

jonathan-j-lee commented 13 hours ago

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/tentative/noopener/coop-noopener-allow-popups.https.html ERROR: 2/7, TIMEOUT: 5/7
/html/cross-origin-opener-policy/tentative/noopener/coop-noopener-allow-popups.https.html noopener-allow-popups ensures that the opener cannot script the openee, but further popups with no COOP can access their opener: noopener-allow-popups/noopener-allow-popups FAIL: 3/7, TIMEOUT: 4/7 step_wait_func: Opener popup.window becomes null Timed out waiting on condition;Test timed out
/html/cross-origin-opener-policy/tentative/noopener/coop-noopener-allow-popups.https.html noopener-allow-popups ensures that the opener cannot script the openee, but further popups with no COOP can access their opener: noopener-allow-popups/same-origin NOTRUN: 6/7, TIMEOUT: 1/7 Test timed out

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

jonathan-j-lee commented 13 hours ago

@DanielRyanSmith @KyleJu Pinged bug about the new timeout: https://crbug.com/344963946#comment4. Please force merge, thanks!