search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.8k stars 3k forks source link

Do not skip all the remaining tests when one worker crashes #46995

Closed WeizhongX closed 3 days ago

WeizhongX commented 5 days ago

When one worker crashes, while tests already assigned to that work will never be run, the tests in other groups can still be run by other workers. There is no need to drain all tests in such scenario.

Ideally test_ended should be called for all such tests with a result SKIP-ped. Chromium handled this separately.

We see this happens on Windows because OSError is raised and PermissionError raised on Mac. We now capture the error and ignore that, in hope the rest of the tests can continue to be run.

Bug: None

WeizhongX commented 3 days ago

The failure on infrastructure/test

/infrastructure/testdriver/click_iframe.html TIMEOUT /infrastructure/testdriver/click_iframe.html - TestRunner hit external timeout (this may indicate a hang) SUITE-END | took 493s

WeizhongX commented 3 days ago

@KyleJu can you help admin merge? The failure is not related with my change. Thanks!