web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.8k stars 3k forks source link

Add Origin-Agent-Cluster opt-out for direct-socket tests. #47009

Closed chromium-wpt-export-bot closed 4 days ago

chromium-wpt-export-bot commented 4 days ago

These direct socket tests don't work as WPT tests with Origin Isolation (kOriginKeyedProcessesByDefault) enabled, since the non-default port of the test server shows up in the lock_url used to determine if direct-sockets are allowed or not, and this breaks the tests. In real-world operation, direct-sockets are used in Chrome apps and Isolated Web Apps, and neither of these will have non-default ports. Opting these three tests out via the Origin-Agent-Cluster header allows them to run in this non-standard test setup.

Bug: 40259221 Change-Id: I7c9349a715005b20ddc48edd5e7813bf749a38c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675462 Reviewed-by: Andrew Rayskiy \greengrape@google.com Commit-Queue: James Maclean \wjmaclean@chromium.org Cr-Commit-Position: refs/heads/main@{#1323503}