search

web-push-libs / pywebpush

Python Webpush Data encryption library
Mozilla Public License 2.0
303 stars 52 forks source link

Create WebPusher send_async #152

Open TobeTek opened 1 year ago

jrconlin commented 1 year ago

I'm curious why you closed this PR. It looks really useful.

TobeTek commented 1 year ago

Hello @jrconlin

I'm curious why you closed this PR. It looks really useful.

Opening the PR had initially been a mistake. My changes were initially intended for internal use. I implemented a send_async method for the WebPusher class.

Looking at https://github.com/web-push-libs/pywebpush/issues/150 and https://github.com/web-push-libs/pywebpush/issues/142, I assumed send_async wasn't on the roadmap.

Going ahead to reopen now, incase it proves helpful in any way.

jrconlin commented 1 year ago

I think it might!

Heh, if there are improvements, don't be afraid to share them. Chances are good someone else might benefit as well.

Thanks!