web-push-libs / pywebpush

Python Webpush Data encryption library
Mozilla Public License 2.0
305 stars 52 forks source link

Copy subscription before altering the keys. #84

Closed Chris-V closed 6 years ago

Chris-V commented 6 years ago

Altering subscriptions reference by changing the keys from string to byte causes hard to debug issues in libraries. For exemple, trying to call json.dumps() after initializing WebPusher throws an error because json cannot handle bytes.

balloob commented 6 years ago

Any chance this could be released to PyPi?

balloob commented 6 years ago

Thanks! ❤️