web-push-libs / vapid

Apps and Libraries to support WebPush VAPID
Mozilla Public License 2.0
90 stars 27 forks source link

bug: "exp" claim should be an integer #102

Closed milanmeu closed 1 year ago

milanmeu commented 1 year ago

The "exp" (Expiry) claim should be an integer not a string. If it's a string the notification won't be shown in Firefox.

jrconlin commented 1 year ago

Ah, I see that this PR was not signed. We require PGP signed commits. I'll redo this one, with a signature and credit this PR. Thanks!