search

web-push-libs / vapid

Apps and Libraries to support WebPush VAPID
Mozilla Public License 2.0
90 stars 27 forks source link

relax 'aud' check #77

Closed samuelcolvin closed 5 years ago

samuelcolvin commented 5 years ago

In unit tests I'm running a dummy server to mock the web push endpoint but running into problems with vapid being too strict about how the aud endpoint looks.

This permits http://localhost:1234 as the aud endpoint. This is no less secure since the current check accepts 127.0.0.1 which is equivalent.

Also test against modern python.

samuelcolvin commented 5 years ago

Any chance this could be reviewed or merged?

jrconlin commented 5 years ago

Sorry, been traveling and in conference this week.

samuelcolvin commented 5 years ago

no problem, thanks.