search

web-push-libs / web-push-csharp

Web Push library for C#
Mozilla Public License 2.0
429 stars 108 forks source link

Cannot send notification with expiration date #41

Closed expertsender-marcinsynak closed 5 years ago

expertsender-marcinsynak commented 6 years ago

"WebPushClient.SendNotification" does not allow sending notification with expiration date.

Internally, it calls "VapidHelper.GetVapidHeaders" which has "expiration" parameter, but it is omitted and it defaults to 12 hours.

It would be nice if we could pass our own value somehow (perhaps through "VapidDetails" object?)

Or maybe there's a way to work around it which I did not find? I'd be grateful for any help.

coryjthompson commented 6 years ago

You are correct - it's hard coded to 12 hours. I will add an option shortly.

Thank you.

coryjthompson commented 5 years ago

VapidDetails.Expiration will exist in next nuget release.

Thank you.

expertsender-marcinsynak commented 5 years ago

Splendid! We'll be waiting for the package update.

expertsender-marcinsynak commented 5 years ago

Hello, is there a chance new NuGet package will appear soon? The last version is from March, 2018, I hope you did not abandon this project completely :)

Best regards.

coryjthompson commented 5 years ago

Hi,

I'll publish a new version within the next week. :)

Thank you.