Fix CI detection to fix Travis tests

web-push-libs / web-push-php

Web Push library for PHP

MIT License

1.71k stars 298 forks source link

Fix CI detection to fix Travis tests #280

Closed baer95 closed 4 years ago

baer95 commented 4 years ago

Debugging GoogleChromeLabs/web-push-testing-service is a pain in the ass and there seems to be logic to skip tests that use it.

This PR fixes the logic that is used to detect CI and skip these tests.

Minishlink commented 4 years ago

This piece of code had been copy/pasted from another test, and should have read "This test only runs on Travis", or rather the check would be that web-push-service-test is installed and running on the machine

I'm not for abandoning tests on CI yet, only if solution 3 of https://github.com/web-push-libs/web-push-php/issues/274#issuecomment-610746518