web-push-libs / web-push-php

Web Push library for PHP
MIT License
1.69k stars 295 forks source link

Drop support for EOL versions of PHP? #341

Closed stephanvierkant closed 6 months ago

stephanvierkant commented 2 years ago

I see this library still supports PHP 7.2, which is End of Life (EOL) for more than a year. Even 7.3 is EOL as of today. The only supported versions are 7.4, 8.0 and 8.1

In my opinion libraries should drop support of PHP versions that are end of life, because it makes contributing to this library much easier. What's the policy about dropping support? (BC break or not? When to drop?)

Would a PR that drops support for 7.2 and/or 7.3 be accepted?

Minishlink commented 2 years ago

Yes