web-push-libs / web-push-php

Web Push library for PHP
MIT License
1.69k stars 295 forks source link

web-push-php API signature change #345

Open sadektouati opened 2 years ago

sadektouati commented 2 years ago

I lost countless hours trying to make it send the payload. I used this code Subscription::create([ 'endpoint' => $endpoint, $p256dh, $keys_auth, 'contentEncoding' => 'aesgcm', ]), Notice I used position parameters and it gives no error (except in the case of "endpoint").

Instead, it should be like this: Subscription::create([ 'endpoint' => $endpoint, 'publicKey' => $p256dh, 'authToken' => $keys_auth, 'contentEncoding' => 'aesgcm', ]),

I think it should raise an error if any of the parameters is provided without a name.