search

web-push-libs / web-push-php

Web Push library for PHP
MIT License
1.69k stars 295 forks source link

Changes in web-token library cause fatal error Class 'Base64Url\Base64Url' not found because of removing "spomky-labs/base64url" #349

Closed lubasq closed 2 years ago

lubasq commented 2 years ago

Hey.

Today i do a fresh install with updates with my composer and find out that one of used packages make some changes which cause a fatal error.

here an error log:

2022-03-01T10:31:37+01:00 DEBUG (7): Class 'Base64Url\Base64Url' not found /2. /home/vagrant/app/src/Notifications/Channels/Push/Push.php(42): Minishlink\WebPush\WebPush->__construct() /1. /home/vagrant/app/vendor/minishlink/web-push/src/WebPush.php(88): Minishlink\WebPush\VAPID::validate()

Take a look at it :)

Look in changes in: https://github.com/web-token/jwt-core/blob/v2.2/composer.json

sorry for unformatted issue, but i dont have much time for now and only want to inform about it and ty for work!

joostdebruijn commented 2 years ago

See PR #350!

Minishlink commented 2 years ago

Hi, thanks @joostdebruijn Could you test on v7.0.0 please?

joostdebruijn commented 2 years ago

It's working fine for me with v7.0.0, but @lubasq is the reporter so I'm curious if that solves the problem for him too. :)

lubasq commented 2 years ago

works fine in v7.0.0, thanks for responding :) closing issue now