search

web-push-libs / web-push-php

Web Push library for PHP
MIT License
1.72k stars 301 forks source link

Import with `use` #375

Closed Rotzbua closed 1 year ago

Rotzbua commented 1 year ago

Is there a rule in phpstan for this?

I could not find any rule. I think this is more a code style thing and phpstan is more a validator rather then a code style tool.

edit: found cs fixer rule: https://cs.symfony.com/doc/rules/import/global_namespace_import.html So up to you which style you prefer.

Minishlink commented 1 year ago

Oh yes, a rule of php-cs-fixer sounds great. I don't really mind which rule is used but let's be consistent everywhere thanks to a rule

Rotzbua commented 1 year ago

@Minishlink Added stricter cs fixer rules, so closed in favor of #377