search

web-push-libs / web-push-php

Web Push library for PHP
MIT License
1.7k stars 295 forks source link

fix: [BREAKING] remove legacy subscription; change subscription interface #394

Open Rotzbua opened 8 months ago

Rotzbua commented 8 months ago

Changes

Breaking:

Feature:

Reference

fixes #381 fixes #345 reference #388

Minishlink commented 7 months ago

Hey sorry I plan to review this this weekend, thanks!

Gugu7264 commented 3 months ago

Hopefully this can be finished & merged soon :)

Gugu7264 commented 3 months ago

@Minishlink Just wondering, what's currently missing in that PR? The required fixes in reviews? (and conflicts)

Minishlink commented 3 months ago

Yes that's right

Minishlink commented 3 months ago

I might delay this to v10 and release v9 at the beginning of july. Let me know @Rotzbua if you have time in the near future for this PR, thank you

cclegend90 commented 2 months ago

Hi, I have over 25k subscribers and need to switch to the new FCM v1 API since the old version will be deprecated soon. When will this library support the v1 API? I'm using Perfecty Push, which depends on this library.

Thanks for the amazing repo!

Minishlink commented 2 months ago

Hello, this library is agnostic about which endpoint is sent by the browser, it only requires compliance with the Web Push standard. Regarding FCM deprecation, Google said that it will still support the old endpoints https://stackoverflow.com/a/77958717 (but anyway this is not a question for this repository but more for Google)

Rotzbua commented 2 months ago

Converted to draft until I have time and back into the php topic.

cclegend90 commented 2 months ago

Thanks for the update! I have one more question: what's the pull request about? Are you planning on supporting the v1 HTTP API too, or is it focused on something else? Looking forward to your response!

Rotzbua commented 2 months ago

@cclegend90 It is just cleanup of obsolete code. The FCM v1 HTTP API (for native apps) is not the Push API (for browser) and not target of this library.

rileysiemens commented 4 days ago

Is there an ETA on when this will be merged/released?