search

web-push-libs / web-push

Web Push library for Node.js
Other
3.26k stars 305 forks source link

migrate urlsafe-base64 to be internal to web-push #786

Closed hikarunoryoma closed 1 year ago

hikarunoryoma commented 1 year ago

Solves: https://github.com/web-push-libs/web-push/issues/785

marco-c commented 1 year ago

LGTM, could you rebase?

hikarunoryoma commented 1 year ago

LGTM, could you rebase?

Done! :)

Let me know if you want me to bump the version number. I was unsure how that is managed

marco-c commented 1 year ago

There seems to be one reference left to fix:

> node ./node_modules/eslint/bin/eslint --ignore-path .gitignore '.'

/home/runner/work/web-push/web-push/test/test-vapid-helper.js
Error:   18:26  error  'urlBase64' is not defined  no-undef

✖ 1 problem (1 error, 0 warnings)
marco-c commented 1 year ago

Unfortunately it looks like the tests are failing

hikarunoryoma commented 1 year ago

Thanks, I'll look to investigate this weekend and actually have JVM and run these test locally on my machine

marco-c commented 1 year ago

@hikarunoryoma still planning on working on this?

haouarihk commented 1 year ago

when is this gonna get merged.

Thanks for the hard work

marco-c commented 1 year ago

when is this gonna get merged.

Thanks for the hard work

There are some failing tests, they need to be fixed first before this can be merged.

haouarihk commented 1 year ago

i fixed the issue with decode @hikarunoryoma

813

marco-c commented 1 year ago

Merged in #813, thank you!