search

web-push-libs / web-push

Web Push library for Node.js
Other
3.26k stars 305 forks source link

fix(sendnotification): fix HttpsProxyAgent error #828

Closed neilning-xc closed 1 year ago

neilning-xc commented 1 year ago

https-proxy-agent 7.x changed the default export https://github.com/TooTallNate/proxy-agents/blob/main/packages/https-proxy-agent/README.md#https-module-example

marco-c commented 1 year ago

The fix looks good to me, but the test is using a proxy that doesn't exist. If we want to test, we actually need to run a proxy locally as part of the tests.

neilning-xc commented 1 year ago

The fix looks good to me, but the test is using a proxy that doesn't exist. If we want to test, we actually need to run a proxy locally as part of the tests.

Oh, I forgot that. I remove that test case if you don't mind

marco-c commented 1 year ago

Thanks!