PushAsyncService

[sp00m]

Introducing PushAsyncService for https://github.com/web-push-libs/webpush-java/issues/101.

I tried to keep the existing coding style and to ensure backward compatibility.

Still WIP because of the following points though:

• CompletableFuture is only available since Java 8, and I did not notice this project still supports Java 7. I've update to Java 8, is that OK?

• I've kept the existing PushService and introduced PushAsyncService to ensure backward compatibility. The shared code has been moved into a parent class AbstractPushService. Because the setters return this to allow chaining, I had to hack around with the usual <T extends AbstractPushService<T>>, which ends up in "unchecked cast" (although safe in this specific case), is that OK?

• I've deprecated PushService#sendAsync, redirecting to PushAsyncService#send instead, is that OK?

• I've been using AHC, but I noticed that only 13 days ago, it is now looking for a new maintainer... I hope it will find one, but in the meantime, is that OK?

• I wanted to add integration tests around PushAsyncService, but I didn't manage to run the existing ones locally... Any specific config I'm supposed to set up first?

Let me know :)

[sp00m]

Hmm, looks like the CI fails on SeleniumTests too, which is the test I don't manage to get working locally either. Not sure it's the same issue though.

[martijndwars]

Sorry for the delay, I've been on vacation for the last two weeks. I've tried to revive the integration tests in testcafe, but I haven't managed to get these to work on Travis CI. The integration tests have been a huge pain point (for all projects in the web-push-libs organization, as far as I'm aware). I'll run some manual tests when I'm back home. I don't expect any problems and I'll merge and release a new version soon after.

[sp00m]

Sorry for the delay, I've been on vacation for the last two weeks. I've tried to revive the integration tests in testcafe, but I haven't managed to get these to work on Travis CI. The integration tests have been a huge pain point (for all projects in the web-push-libs organization, as far as I'm aware). I'll run some manual tests when I'm back home. I don't expect any problems and I'll merge and release a new version soon after.

Sure, no worries, thanks for your time :)

[sp00m]

Hey @MartijnDwars, any update for this PR? Did you get a chance to run manual tests yet?

[martijndwars]

Yep, ran the tests a while back but forgot to merge. Great work!

[fecheromero]

when do you think we could get this in a new release?

[martijndwars]

I published version 5.1.1 last night (CC @sp00m @fecheromero).