search

web-push-libs / webpush-java

Web Push library for Java
MIT License
323 stars 112 forks source link

Apply gcm header to fcm endpoints #84

Closed CKPalk closed 5 years ago

CKPalk commented 5 years ago

Google announced that old gcm endpoints need to be redirected to fcm.

If the GCM auth key is supplied, apply it to both gcm and fcm endpoints.

CKPalk commented 5 years ago

I tried to match what I saw in the JS library as closely as I could. https://github.com/web-push-libs/web-push/blob/master/src/web-push-lib.js#L255-L257

martijndwars commented 5 years ago

Thank you! I see the CI build broke -- I'll try to fix this over the weekend so we can merge your changes.

CKPalk commented 5 years ago

@MartijnDwars Checking in to see if we can get this merged and release asap. Thank you

martijndwars commented 5 years ago

I've changed .travis.yml, but if I rebuild your PR Travis will pick up the old .travis.yml. Can you add a new commit/amend the previous commit to trigger Travis?

CKPalk commented 5 years ago

Nice, looks like that fixed the build

martijndwars commented 5 years ago

I released version ~5.0.3~ 5.0.2 to Maven Central, it should be available within a few hours. Thanks for contributing!

CKPalk commented 5 years ago

Thank you! I think you meant version 5.0.2 was released.