search

web-push-libs / webpush-java

Web Push library for Java
MIT License
323 stars 112 forks source link

Support for BouncyCastle bcprov-jdk16? #97

Closed dherediat97 closed 4 years ago

dherediat97 commented 5 years ago

Hello,

my question is:

is possible that this library have support for bcprov-jdk16(Bouncy Castle)?

The method BigIntegers.fromUnsignedByteArray of bouncy castle dont exists in bcprov-jdk16 but yes in bcprov-jdk15on.

I know that i open and closed a related issue about this (https://github.com/web-push-libs/webpush-java/issues/95) but is different i think.

Greetings @dherediat97

martijndwars commented 5 years ago

We'd have to check the implications of upgrading BouncyCastle. For the call to BigIntegers.fromUnsignedByteArray, the implementation does nothing special. We might as well inline the creation of the BigInteger and remove the call into BouncyCastle. Would that already solve your problem?

dherediat97 commented 5 years ago

Yes @MartijnDwars,

is very possible(i am 100% sure that are more errors or not, because when i change the version the first error is that, but if only is this is solved , but i dont know if there are more errors after).

Sorry for the delay.

greetings @dherediat97

mchiba52 commented 5 years ago

The inline will help as I am getting an error on java.math.BigInteger that is called from the BC function BigIntegers.fromUnsignedByteArray