Feature/notification class api improvements

web-push-libs / webpush-java

Web Push library for Java

MIT License

323 stars 112 forks source link

Feature/notification class api improvements #98

Closed meamuri closed 5 years ago

meamuri commented 5 years ago

Changes:

jvm target version up to 8
add notification builder and constructor with ttl
write some test for notification class

martijndwars commented 5 years ago

Thanks for the contribution, great work! Do you think you can keep the source/target Java 7-compatible? I'd hate to disappoint Java 7 users (which, surprisingly, is still a thing in many companies).

meamuri commented 5 years ago

Thank you for your feedback! Yep, I updated version to 8 only to make it able for Duration api usage. It isn't necessary and I reverted this changes. Take a look at current version please 😄

martijndwars commented 5 years ago

Looks great, thanks! I'll release a new version to Maven Central in the next few days.