search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
657 stars 170 forks source link

fix: update input label for pt locale #131

Closed brandon-eb closed 2 years ago

brandon-eb commented 2 years ago

Hello! In Portuguese they use AAAA instead of YYYY for dates. This PR updates the inputFormat to use AAAA when the Portuguese locale is selected.

RichardLindhout commented 2 years ago

Hey Brandon, can you back this up by some external source on wikipedia it says for Portugal: https://en.wikipedia.org/wiki/Date_format_by_country

Portugal Yes Yes No Mostly (dd/mm/yyyy) and (dd-mm-yyyy); some newer documents use (yyyy-mm-dd).[134] NP EN 28601
brandon-eb commented 2 years ago

If you look on the "Date" wikipedia entry in Portuguese you can see they list the date format as AAAA-MM-DD: https://pt.wikipedia.org/wiki/Data

RichardLindhout commented 2 years ago

Thanks! Will try to release a new version next week with this fix :)

brandon-eb commented 2 years ago

Great! Thanks!

brandon-eb commented 2 years ago

@RichardLindhout Any updates on when this will be released? My team would like to include this change in our next release.

RichardLindhout commented 2 years ago

I forgot about it, thanks for your PR!