search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
642 stars 166 forks source link

Material You #206

Closed iM-GeeKy closed 1 year ago

iM-GeeKy commented 1 year ago

@RichardLindhout Any feedback would be appreciated here. It appears react-native-paper will soon get version 5 into stable and this could potentially resolve the following

This will seamlessly detect the paper version, so it should be backward compatible with version 2. I've been using a patch of this with a lot of success in my own application and for the longevity of this repo, I think it's paramount this gets accomplished. I'm happy to help where possible, time permitting.

bombillazo commented 1 year ago

Im willing to test this with RNP5

RichardLindhout commented 1 year ago

Looking good will try to merge this week or next week!

bombillazo commented 1 year ago

Has this been released? seems like 0.9.2 doesnt have these changes or am I incorrect?

iM-GeeKy commented 1 year ago

Has this been released? seems like 0.9.2 doesnt have these changes or am I incorrect?

Not to my knowledge, I've still been using patch-package in my project.

bombillazo commented 1 year ago

Same here, I want to test this PR so I dont have to be patching up, also would try to contribute fixes to this repo itself too

rrufus commented 1 year ago

@RichardLindhout Thank you for the work on this library! Wondering what timelines look like for releasing a new version with these merged changes?

I'm having the issue described here: https://github.com/web-ridge/react-native-paper-dates/issues/189#issuecomment-1346987334 and I think releasing a new version with these merged changes might fix it?