search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
642 stars 166 forks source link

toUpperCase use causes an issue for Turkish language #231

Closed efkan closed 6 months ago

efkan commented 1 year ago

Capital 'i' letters in translated texts are displayed wrong for Turkish lang because toUpperCase(text) doesn't work as expected.

The text in the screenshot should have been "TARİH SEÇ" but it is displayed as "TARIH SEÇ".

To overcome this issue we should write uppercase texts in the translation file.

image

iM-GeeKy commented 1 year ago

Great find, PR's welcome!

RichardLindhout commented 1 year ago

In material 3 uppercase is not used anymore maybe we should turn the default to non uppercase

meliades commented 1 year ago

You can use toLocaleUpperCase('TR') for fix.

RichardLindhout commented 1 year ago

You also can set uppercase=false as props in material 3 uppercase is not even there anymore 👌🏻

Op za 11 feb. 2023 om 22:18 schreef meliades @.***>

You can use toLocaleUpperCase('TR') for fix.

— Reply to this email directly, view it on GitHub https://github.com/web-ridge/react-native-paper-dates/issues/231#issuecomment-1426878562, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRARLGR35KLOHBO3YFXQLWW762TANCNFSM6AAAAAATO4W4SE . You are receiving this because you commented.Message ID: @.***>

-- Richard Lindhout | Eigenaar Bel mij +31 6 43 42 45 67 <+31643424567>

Nijverheidsweg 1A, 4695 RC Sint-Maartensdijk KVK 56845367 BTW NL002365659B60 IBAN NL93 BUNQ 2038 9661 33 WEB webRidge.nl https://webridge.nl/

RichardLindhout commented 6 months ago

Date picker input does not uppercase anymore now (on v3)

RichardLindhout commented 6 months ago

Or you can use uppercase={false} if you're on m2