search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
642 stars 166 forks source link

MM.DD.YYYY needs to be translated #232

Closed efkan closed 5 months ago

efkan commented 1 year ago

We should use translated letters for this kind of text. For instance, it should be 'GG.AA.YYYY' and it refers to 'DD.MM.YYYY'.

image

iM-GeeKy commented 1 year ago

PR's welcome!

mikib0 commented 1 year ago

Hey @iM-GeeKy, I want to work on this. My current idea is to add another property (like dateFormat) to the translations object, is that a good approach?

iM-GeeKy commented 1 year ago

Hi @mikib0 thanks for wanting to work on this! That approach seems fine and it should be robust enough to accommodate other translations. We will just have to make sure it defaults since the other translations will not have the new property you will be adding.

I'm going to rope @RichardLindhout into the discussion, he might have an idea and is much more familiar with the code, which I'm still getting familiar with 🙂.

I see @RichardLindhout put a comment here which id assume is one spot where your code change will be.

mikib0 commented 1 year ago

Yes exactly. Thanks for pointing me there @iM-GeeKy. I am going to make a draft PR and start working on it.

RichardLindhout commented 6 months ago

This should be detected automatically using the locale and the INTL implementation. If this does not work in your language it's a bug with intl in react native / ios / android

Have you correctly configured your locale in your language?

github-actions[bot] commented 6 months ago

Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).

github-actions[bot] commented 5 months ago

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.