search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
642 stars 166 forks source link

Setting time to 12:00 -> 00:00 #239

Closed SimonErlandsson closed 1 year ago

SimonErlandsson commented 1 year ago

Current behaviour

When selecting time 12 for the hour, it is set to 00 instead. Using 24h mode.

Expected behaviour

When setting the time to ex. 12:00, the time should indeed be set to 12:00 instead of 00:00.

How to reproduce?

Import date-picker, open up time-picker with 24h mode and select 12.

Preview

https://user-images.githubusercontent.com/3949779/212188693-74909582-972e-41c3-8763-8e3378c20563.mp4

iM-GeeKy commented 1 year ago

PRs welcome!

iM-GeeKy commented 1 year ago

At first glance I did notice 00 is appearing twice in the clock. Its correct appearance should be as follows with "00" and "12".

Screenshot 2023-01-15 at 11 32 41 AM
iM-GeeKy commented 1 year ago

Closed by https://github.com/web-ridge/react-native-paper-dates/pull/247

SimonErlandsson commented 1 year ago

https://user-images.githubusercontent.com/3949779/217999406-f93e0b62-2382-4da5-b6f2-389947a7153c.mp4

Thank you. There seem to be some improvements with the new version. Although, if the current value entered for the hour is less than 12, then the behaviour is still wrong. See the clip attached.