search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
642 stars 166 forks source link

Selected current date text color same as background #240

Closed bombillazo closed 1 year ago

bombillazo commented 1 year ago

Current behaviour

Selecting the current date will not show the date since it is the same color as the primary background select color. It works on other non-current dates

Expected behaviour

The date text color of the current date, when selected, contrasts with the select background color

How to reproduce?

Add custom styling to your RN Paper theme.

Preview

image image

What have you tried so far?

Not sure how to fix

Your Environment

software version
ios x
android x
react-native x.x.x
react-native-paper x.x.x
node x.x.x
npm or yarn x.x.x
expo sdk x.x.x
RichardLindhout commented 1 year ago

We need to check with the npm 'color' package if the color is ligth/dark to change text color

RichardLindhout commented 1 year ago

I have also seen this in dark mode

iM-GeeKy commented 1 year ago

I'll take a look this weekend.

iM-GeeKy commented 1 year ago

@bombillazo Feel free to use patch-package to apply the changes from this pull request until we can get this merged.

iM-GeeKy commented 1 year ago

Closed by https://github.com/web-ridge/react-native-paper-dates/pull/241