search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
662 stars 170 forks source link

Android - Performance when using range picker on android - expo - Hermes #245

Closed LeoAnt02 closed 1 year ago

LeoAnt02 commented 1 year ago

Current behaviour

Everything works fine on web/ios - but with android I've noticed a drop in performance when using the range picker

i'm using expo 47.0.12 react-native-paper-dates : 0.11.14 react-native: 0.70.5 node v16.18

How to reproduce?

Here's a snack https://snack.expo.dev/@crawl007/react-paper-dates-exemple-range

You can easily replicate with the same code and use Hermes engine in app.json

AshwinTayson commented 1 year ago

Any update on this? it takes 3-4 seconds to render the calendar view

LeoAnt02 commented 1 year ago

Issue still here and get even worse

Before : with version 0.15.2 Android was slow to open and close the modal Ios was fast, normal no issue

Now with version 0.18.12 Both IOS and android are slow, and saving a date range take 2-3sec to close the modal

Any update on this @iM-GeeKy ?

github-actions[bot] commented 1 year ago

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

github-actions[bot] commented 1 year ago

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.