search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
662 stars 170 forks source link

24 hour bug #247

Closed iM-GeeKy closed 1 year ago

iM-GeeKy commented 1 year ago

Motivation

Remarks

  1. As part of the ticket above I noticed 00 is appearing twice in the clock. Its correct appearance should be as follows with "00" and "12". That is addressed as part of this. image

  2. "00" was also appearing in the 12 hour clock which isn't standard. According to the material 3 docs it should be 12 instead. This is addressed as part of this. image

@RichardLindhout Please test and verify existing functionality still behaves as expected.

RichardLindhout commented 1 year ago

LGTM! Thanks for all your investments, feel free to add your name to the authors :)