search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
640 stars 164 forks source link

Type error required to add accessibilityLabelledBy, accessibilityLanguage #254

Closed nityanantan23 closed 1 year ago

nityanantan23 commented 1 year ago

Current behaviour

produces a type error where it is required to add accessibilityLabelledBy, accessibilityLanguage
The fixed PR from react native paper : https://github.com/callstack/react-native-paper/pull/3603

Expected behaviour

Shouldn't produce the type error, initially it was in react native paper as well but in the latest build they fixed it

How to reproduce?

https://snack.expo.dev/@nity/witty-pudding same code as in the example https://web-ridge.github.io/react-native-paper-dates/docs/date-picker/input-date-picker

Preview

image

What have you tried so far?

none

Your Environment

software version
ios x
android x
react-native 0.71.1
react-native-paper 5.1.4
node x.x.x
npm or yarn 1.22.19
expo sdk x.x.x
github-actions[bot] commented 1 year ago

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

nityanantan23 commented 1 year ago

https://snack.expo.dev/@nity/witty-pudding

iM-GeeKy commented 1 year ago

This is resolved in 0.14.0, here is a slightly updated snack https://snack.expo.dev/@fitzwabs/602241. If this is still an issue feel free to reopen with an reproducible example.