search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
640 stars 164 forks source link

Range active indicator color not showing properly #283

Closed Strengthless closed 1 year ago

Strengthless commented 1 year ago

Current behaviour

The color of active indicator for Range date picker remains light purple, while primary color is set to dark red...

How to reproduce?

const theme = {
  ...DefaultTheme,
  colors: {
    ...DefaultTheme.colors,
    primary: '#1F1717',
  },
};

Preview

Strengthless commented 1 year ago

Fixed. Looks like you have to declare the color for primaryContainer...

Apparently it's not calculated automatically based on primary??

Can close now, if this is intended behaviour.

github-actions[bot] commented 1 year ago

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

iM-GeeKy commented 1 year ago

The underlying theming is derived from the parent library https://callstack.github.io/react-native-paper/docs/guides/theming.

github-actions[bot] commented 1 year ago

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.