web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
640 stars 164 forks source link

Patch-package: not found #293

Closed iM-GeeKy closed 1 year ago

iM-GeeKy commented 1 year ago

Temporary Fix

If you are experiencing this issue, use 0.16.2 for now until this issue is resolved.

Current behaviour

As part of release 0.18.0, a bug was introduced causing CI pipelines to fail during dependency installation of patch-package. This was needed to patch issue related to accessibility in the parent library.

Expected behaviour

The library should install correctly.

How to reproduce?

Install dependencies via npm install or yarn install in a github workflow.

Preview

Screenshot 2023-06-03 at 5 12 55 PM

What have you tried so far?

Two possible solutions come to mind.

  1. Add patch-package to the dependencies. The downfall here is the bundle size will be slightly larger until the patch can be removed.
  2. Revert the accessibility changes which will cause the library to look funny with larger text font sizes.

@RichardLindhout What are your thoughts?

Your Environment

software version
ios 16.4
android x
react-native 0.71.8
react-native-paper 5.8.0
node 16.16.0
npm or yarn yarn
expo sdk 48.0.19
iM-GeeKy commented 1 year ago

Closed by https://github.com/web-ridge/react-native-paper-dates/pull/294