search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
662 stars 170 forks source link

Change edit icon color #299

Closed sdfricke closed 1 year ago

sdfricke commented 1 year ago

Ask your Question

Hello, I am updating the version of this package, and the pencil edit icon in the modal header is now black. I don't see a prop available to change it back to white like it was in version 0.8.x. If I update the theme to use white for the theme.colors.text, then the numbers in the calendar are also white and can't be seen. Wondering if there is a way to just target the color of the edit icon? Thank you.

Screen Shot 2023-06-22 at 4 38 28 PM

iM-GeeKy commented 1 year ago

@sdfricke Hi, the color of the icon in version 3 currently corresponds to onSurface. Hopefully that helps.

sdfricke commented 1 year ago

@sdfricke Hi, the color of the icon in version 3 currently corresponds to onSurface. Hopefully that helps.

Thanks for getting back to me @iM-GeeKy! I don't believe I'm using v3, because changing onSurface changes day of the week and month/year text. Sorry for my ignorance, but is there a way to do this while not using version 3? And if I wanted to use version 3, would that be as simple as just adding version: 3 to my theme object? I tried that but it didn't seem to work. Screen Shot 2023-06-22 at 4 58 47 PM

iM-GeeKy commented 1 year ago

Yeah, we are using the theme object from the parent library react-native-paper. If you think this is a bug, then feel free to create a reproducible example.

github-actions[bot] commented 1 year ago

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

JacobWNutrien commented 11 months ago

Can this be re-opened? I can't find a workaround to change the editIcon color even after adding version: 3 and setting onSurface to my desired editIcon color. Here's a reproducible example