search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
637 stars 161 forks source link

AM/PM Is hardcoded, which is tough when trying to localize. #365

Closed Rob117 closed 5 months ago

Rob117 commented 5 months ago

Current behaviour

AM and PM seem to be hardcoded into the Timepicker

Expected behaviour

I'd like for AM and PM be a prop so I can change them, because in Japanese they are 午前 and 午後 and AM/PM is difficult to understand.

What have you tried so far?

I think at this point the only thing I can do is patch the library file, which is probably not ideals

iM-GeeKy commented 5 months ago

PRs are welcome!

RichardLindhout commented 5 months ago

It should automatically change itself to be 24h if your locale is correct, please give us a snack with your locale and try to find why it does not detect 24h for your locale.

github-actions[bot] commented 5 months ago

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

RichardLindhout commented 5 months ago

Did you set up your locale?

github-actions[bot] commented 5 months ago

Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).