search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
637 stars 161 forks source link

feat: Make it possible to start the week on monday #389

Closed gregoire-jianda closed 1 month ago

gregoire-jianda commented 1 month ago

Add the option to start weeks on Monday, default behavior is unchanged.

closes #20

gregoire-jianda commented 1 month ago

I missed the Swiper component, my bad !

iM-GeeKy commented 1 month ago

Hey @gregoire-jianda I'll try to find some time to pull this down and test it (it might not be until this weekend). I'll let @RichardLindhout take a look too and merge it if he's available. If not, I'll try to find another person to test it out and then we can get it merged 👍🏻. Thanks for the PR though!

iM-GeeKy commented 1 month ago

I've started looking at this and it appears the DatePickerInput does not start with Monday even with the startWeekOnMonday set to true (this was iOS, I haven't made it android or web yet). @gregoire-jianda Would you mind taking a look at this? It's looking great though! Nice work!

gregoire-jianda commented 1 month ago

Good catch @iM-GeeKy, fixed!

iM-GeeKy commented 1 month ago

Good catch @iM-GeeKy, fixed!

Great job man! We really appreciate the pull request!