web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
637 stars 161 forks source link

DatePickerModal jump wildly when landscape in IOS device #391

Closed UIT19521334 closed 1 month ago

UIT19521334 commented 1 month ago

Current behaviour

The DatePickerModal component jumps wildly when the device is in landscape mode on iOS using react-native-paper-dates.

Expected behaviour

I expect the DatePickerModal component to remain stable and not jump when the device is switched to landscape mode on iOS.

How to reproduce?

  1. Open the app on an iOS device.
  2. Navigate to a screen where the DatePickerModal component is used.
  3. Rotate the device to landscape mode.
  4. Observe the DatePickerModal jumping wildly

Preview

https://github.com/web-ridge/react-native-paper-dates/assets/67258104/8da4c8ac-6fe3-45f7-90c0-5c14447f2745

What have you tried so far?

Your Environment

software version
ios 17.4
android x.x.x
react-native 0.73.1
react-native-paper 5.11.6
node 21.7.2
npm or yarn yarn
iM-GeeKy commented 1 month ago

@UIT19521334 This appears to be linked to this pull request feel free to try it out and fix the PR if it is a proper solution!

UIT19521334 commented 1 month ago

Thank you, you saved my time. I am very happy to have fixed it in the node module with the following comment. I hope this bug will be fixed in the next version.

iM-GeeKy commented 1 month ago

Thank you, you saved my time. I am very happy to have fixed it in the node module with the following comment. I hope this bug will be fixed in the next version.

I'll test it and try to get it merged in the next version. Thanks!

iM-GeeKy commented 1 month ago

simulator_screenshot_5584DDFF-9BDE-450E-B193-CD5EFE6FF09E

@UIT19521334 Did the proposed fix, make the calendar look like this? It seems to fix the jump, but doesn't appear to be fully responsive, so it needs some work still apparently.