search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
637 stars 161 forks source link

Render Error for DatePickerInput component: "Check the render method of 'Month'" #392

Open kalyncoose opened 1 month ago

kalyncoose commented 1 month ago

Issue: DatePickerInput component starts to render but crashes when attempting to render the Month child component inside the 'Calendar'.

image

Resolution: We noticed the peerDependencies for react-native-paper is an asterisk * which is a bad idea for ensuring compatibility and letting end users know what version they should be using at a minimum. We upgraded react-native-paper from 5.3.1 to 5.12.3 which resolved the rendering issue - now the DatePickerInput can fully render and load the calendar (albeit pretty slow in a debug mode app). Side note: when upgrading to the new react-native-paper version we had to change an import of Provider to PaperProvider for react-native-paper.

https://github.com/web-ridge/react-native-paper-dates/blob/9da295e919c3b4c68ee01b3770dda6646a34b873/package.json#L87

Suggestion: Please put down actual version numbers instead of asterisks for the peer dependencies of this package.

github-actions[bot] commented 1 month ago

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

chamellion commented 1 week ago

Same issue here