search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
637 stars 161 forks source link

Add support for test IDs #395

Closed dr-zr closed 1 week ago

dr-zr commented 1 week ago

Is your feature request related to a problem? Please describe. The current version of the library is missing support for test IDs on dismiss & confirm buttons thus preventing automation testing.

Describe the solution you'd like Add dismissButtonTestId & confirmButtonTestId like other similar libraries have (i.e. https://www.npmjs.com/package/react-native-modal-datetime-picker#available-props )

iM-GeeKy commented 1 week ago

PRs are welcome!

github-actions[bot] commented 1 week ago

Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).

dr-zr commented 1 week ago

Looks like the test IDs are already available

https://github.com/web-ridge/react-native-paper-dates/blob/06f9a6f445fa374a3804619b28d02682011be1b6/src/Date/DatePickerModalHeader.tsx#L45 and https://github.com/web-ridge/react-native-paper-dates/blob/06f9a6f445fa374a3804619b28d02682011be1b6/src/Date/DatePickerModalHeader.tsx#L53

Which is good enough 👍