search

web-ridge / react-native-paper-dates

Smooth and fast cross platform Material Design date and time picker for React Native Paper
https://www.reactnativepaperdates.com
MIT License
658 stars 170 forks source link

TimePickerModal uses different time formats for locale="fr-CA" between Android and iOS #86

Closed colinmatthewlee closed 2 years ago

colinmatthewlee commented 3 years ago

For TimePickerModal, I am expecting a 24-hour-clock format using locale="fr-CA".

I get the 24-hour format for iOS simulators, but for android emulators I am stuck with the am/pm format.

There was a similar issue in #24 , which was closed but didn't seem to fix the issue for me.

iOS simulator Screen Shot 2021-07-20 at 5 55 22 PM

Android emulator Screen Shot 2021-07-20 at 5 54 30 PM

I am using "react-native-paper-dates": "^0.4.6", and "react-native": "^0.63.4"

RichardLindhout commented 3 years ago

Should not happen:

Have you followed the android-caveats section? https://github.com/web-ridge/react-native-paper-dates#android-caveats

colinmatthewlee commented 3 years ago

Fixed, thank you. I added the code into my index file but didn't add a "fr" version