search

web-ridge / react-native-paper-tabs

Smooth and fast cross platform Material Design Tabs for React Native Paper
https://reactnativepapertabs.com
MIT License
199 stars 35 forks source link

Stopped working after upgrade to react native 0.72.1 #51

Closed lelimit closed 1 year ago

lelimit commented 1 year ago

Changing tab results in: Uncaught TypeError TypeError: indicatorRef.current.setNativeProps is not a function at (...........\node_modules\react-native-paper-tabs\lib\module\internal.ts:41:34)

AlexSirenko commented 1 year ago

I faced the same.

AlexSirenko commented 1 year ago

Do you have any workarounds here?

RichardLindhout commented 1 year ago

I'm looking into it!

RichardLindhout commented 1 year ago

Hi it seems to be working fine for me on latest react-native / expo. It looks like it was added back to Fabric too a while ago. https://github.com/facebook/react-native/commit/1d3fa40c59b234f21f516db85c322ec0ed0311e0 so it should work again in the future I don't know if it's in latest released react native yet

Moving away from setNativeProps would mean introducing reanimated on native and a rewrite (which could be good since many have this dependency anyway, but not in the mood for this right now :)

Are you using Fabric?

RichardLindhout commented 1 year ago

Ah it's only on the web version right? I don't use setNativeProps on native. Hmmm. Looking into it

RichardLindhout commented 1 year ago

Works now, I moved away from setNativeProps