web-ridge / react-native-paper-tabs

Smooth and fast cross platform Material Design Tabs for React Native Paper
https://reactnativepapertabs.com
MIT License
201 stars 36 forks source link

TypeError: this._icon.setNativeProps is not a function (it is undefined), js engine: hermes #65

Closed forki closed 9 months ago

forki commented 9 months ago

Current behaviour

With expo SDK 50 we get:

TypeError: this._icon.setNativeProps is not a function (it is undefined), js engine: hermes

this happens when you change a tab and both tabs have Icons. If we remove the icons, then tab changing is still fine.

Expected behaviour

App should not crash

Your Environment

software version
react-native 0.73.2
react-native-paper ~5.12.3
expo sdk SDK 50
RichardLindhout commented 9 months ago

Should be fixed in newer release. Are you on latest version?

https://github.com/web-ridge/react-native-paper-tabs/commit/a85eaaf0f7fb3227a4a87b0808fda91495167813

fwestling commented 9 months ago

I'm getting this error as well, just installed the library fresh. Versions:

Kinjalrk2k commented 8 months ago

Same issue on:

Any resolutions?

riteshreg commented 8 months ago

same issue work with out icon

cyril36 commented 8 months ago

Same issue

I just had the same issue with version : expo: ~50.0.11 "react-native-pager-view": "6.2.3", "react-native-paper": "^5.11.0", "react-native-paper-tabs": "^0.10.3",

Fixed

I have install : "react-native-paper-tabs": "^0.10.4", (i dont think it change anything :D ) and explicitly installed : "@expo/vector-icons": "^13.0.0",

And the issue is fixed :+1:

Note

I can see that the issue also exist installing @expo/vector-icons": "^14.0.0 so it is important to install "@expo/vector-icons": "^13.0.0",