web-scrobbler / web-scrobbler

Scrobble music all around the web!
https://web-scrobbler.com
MIT License
2.47k stars 549 forks source link

Scrobbling from official "Topic" YouTube artist profiles #2056

Closed hans-juergen closed 5 years ago

hans-juergen commented 5 years ago

Describe the bug YouTube has automatically created official "Topic" channels for many artists where the artist may not be mentioned in the individual video titles, so Web Scrobbler does not recognise the artist and album, although both exist on Last.fm. The term " - Topic" is always used in the name of the artist profile though, so it could be used as a search filter.

How to reproduce

  1. Go e.g. to 'Ian Cussick – Topic' https://www.youtube.com/channel/UCZ_EF_scJsOgOhKJk6v9cKw
  2. Click on any of the videos with 'Ian Cussick - Topic' in the title
  3. See the grey Web Scrobbler icon and click on it - no info except the title of the song

Expected behavior Web Scrobbler should use the " - Topic" indicator to fill in the artist and album title automatically.

Environment (please complete the following information)

alexesprit commented 5 years ago

That's bad. The connector is supposed to work exactly as you described.

alexesprit commented 5 years ago

I'll publish a patch update in a few hours.

hans-juergen commented 5 years ago

Great, thank you!

hans-juergen commented 5 years ago

I just tested it with version 2.22.3, and it is better than before, but still not fixed. The track title is automatically filled in, and the artist name has " - Topic" still added. So Last.fm recognises it, and the track gets scrobbled (green icon, not greyed out), but creates a wrong database entry. "- Topic" should be used to trigger the search, but must be deleted from the actual scrobble then. Probably it would also fill in the correct album afterwards as well.

Tested with the Topic channel for Guy Forsyth and his album Steak: https://www.youtube.com/playlist?list=OLAK5uy_la5tx0VM88aXjKhDv1pSCp9TYcMYUuzvc

alexesprit commented 5 years ago

@hans-juergen What language have you selected on YouTube? I have English language selected, and "Topic" suffix is not applied: image

This feature works correctly if language is English only.

Edit: I can add support for other languages, but I want to make sure the issue because of non-English language.

hans-juergen commented 5 years ago

You're right, I'm using German, and actually it says " -Thema" in my browser, sorry.

alexesprit commented 5 years ago

Thanks for the info!

I'll update the code to support "Thema" label along with "Topic" one. If you want, you can submit a new issue as a reminder for me.

Currently, the extension searches for "Topic" string only, and does not support any other strings in different languages. YouTube has a lot of languages supported, so it's not an easy task to fix the issue for ALL languages (I'll fix it for German and few popular ones).

In future, as an alternative solution, I want to add a feature to parse the video description. AFAIK every "topic" video has an autogenerated description, which has a common format for different videos, and the most important thing it's language-independent. This feature requires a lot of testing, so I won't publish it in next updates.

hans-juergen commented 5 years ago

Right, in the video description it always says "Auto-generated by YouTube." in English as the last line, although I'm currently using German on YouTube.

kakolykia commented 5 years ago

I have the same problem. It is really disturbing ((

kakolykia commented 5 years ago

BTW, i use Russian language

alexesprit commented 5 years ago

Sorry, I completely forgot I was assigned to the issue.

It should be fixed now for EN, RU, DE and some other languages.

Note that I used different approach to cut "Topic" suffix, so let me know if you find any regressions.

hans-juergen commented 5 years ago

Thanks Alexey, I just checked with two albums by Forq, and it works fine with version 2.23.3 in Opera with German language setting. :-)

kakolykia commented 5 years ago

Sorry, I completely forgot I was assigned to the issue.

It should be fixed now for EN, RU, DE and some other languages.

Note that I used different approach to cut "Topic" suffix, so let me know if you find any regressions.

Greetings. That's how it looks like when i try to scrobble from "topic" video. I use Vivaldi browser verison 2.8.1664.40 Сниnmnbmмок

alexesprit commented 5 years ago

@kakolykia could you post an URL to this video?

kakolykia commented 5 years ago

@kakolykia could you post an URL to this video?

https://www.youtube.com/watch?v=g1TM_o5lslY

Here you are

alexesprit commented 5 years ago

@kakolykia thanks! I submitted a new issue (for history).

I've fixed the issue, and will publish a patch update soon.

hans-juergen commented 4 years ago

Seems to be broken again in version 2.31.0, at least when using the German version of YouTube in Opera, e.g. for this album:

https://www.youtube.com/playlist?list=OLAK5uy_m_IsNiaA0liY43wylqjm-FOtzfFPTmKzM

The artist field reads "Poco - Thema", and album and album artist are empty then.

By the way, thanks for the new feature of being able to edit a scrobble when you are not in the active browser tab, very handy.

alexesprit commented 4 years ago

There's no "Topic" support anymore, but the extension should get the track info from the video description. I'll check this one.

alexesprit commented 4 years ago

@hans-juergen the videos from that playlist are detected by the extension on German version, as well as on English version.

image

Could you copy the video description and post it here?

hans-juergen commented 4 years ago

That's strange, maybe it works now, because I edited while scrobbling? Before I did that with all 9 songs from the album, they all had Poco - Thema as the artist. My screenshot looks the same, as I had saved my edits:

Web Scrobbler automatic parsing of Poco Legend

I will pay attention if this happens again and make a screenshot then before editing. By the way, the character between the title and the artist in the description is a dot, not a hyphen, but I don't know if that would make a difference.

alexesprit commented 4 years ago

I will pay attention if this happens again and make a screenshot then before editing.

If you find a way how to reproduce it, please let me know. You can open a new issue, if you want.

By the way, the character between the title and the artist in the description is a dot, not a hyphen, but I don't know if that would make a difference.

Yes, that's expected.

chiyochichi commented 1 year ago

image updated to 3.0.15 and still have this damn issue

misaka00251 commented 10 months ago

I'm still having this issue on v3.4.0..."Topic" in Chinese is "主题".

image